You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first commit shifts things to be soley driven off of the provider-specific version of rateLimitSeconds and can be found in 54b8e84. It also removes an unnecessary default value. This commit should have no user visible impact and is intended to make things more directly tied to the value's new location.
The second makes a pass through things removing all of the references to the original global rateLimitSeconds with the exception of the settings value itself since that needs to live on for now so that it can be migrated to the provider specific field 2151b5f. Afaik this commit should have no meaningful impact on the extension.
Set a rate-limit in the advanced section before updating to this code. Update and see that the value you set is copied over to all of your profiles. You can then go into each profile and change the values to something that makes sense for the specific provider. Once saved the value should be tied to the provider.
If no value is set before you update, e.g. 0s, that 0s value will be copied to all the profiles as well.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Not sure if this one needs a changeset or not. It's definitely a patch-level change, but doesn't really have anything that I think would warrant mention in the CHANGELOG.
lgtmThis PR has been approved by a maintainersize:MThis PR changes 30-99 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
size:M
Context
This PR bundles fixes & cleanup around
rateLimitSecondsafter https://github.com/RooVetGit/Roo-Code/pull/2376/files 🚢ed.Implementation
The first commit shifts things to be soley driven off of the provider-specific version of
rateLimitSecondsand can be found in 54b8e84. It also removes an unnecessary default value. This commit should have no user visible impact and is intended to make things more directly tied to the value's new location.The second makes a pass through things removing all of the references to the original global
rateLimitSecondswith the exception of the settings value itself since that needs to live on for now so that it can be migrated to the provider specific field 2151b5f. Afaik this commit should have no meaningful impact on the extension.Screenshots
No user visible changes are intended.
How to Test
(copied from #2376 (comment))
Set a rate-limit in the advanced section before updating to this code. Update and see that the value you set is copied over to all of your profiles. You can then go into each profile and change the values to something that makes sense for the specific provider. Once saved the value should be tied to the provider.
If no value is set before you update, e.g. 0s, that 0s value will be copied to all the profiles as well.
Get in Touch
rwmcfa1
/cc #2376 as realted
Important
Refactor to remove global
rateLimitSecondsand shift to provider-specific configuration.rateLimitSecondsfromroo-code-defaults.tsandClineProvider.ts.Cline.tsto useapiConfiguration?.rateLimitSecondsinstead of globalrateLimitSeconds.rateLimitSecondshandling fromwebviewMessageHandler.tsandExtensionStateContext.tsx.ExtensionMessage.tsandWebviewMessage.tsto removerateLimitSecondsreferences.ClineProvider.test.tsto remove tests related torateLimitSeconds.This description was created by
for 2151b5f. It will automatically update as commits are pushed.